-
Notifications
You must be signed in to change notification settings - Fork 207
ManagedIdentityClient(..., client_capabilities=["cp1"]).acquire_token_for_client(..., claims_challenge="...") #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eca0556
to
9b50e14
Compare
2e6dc04
to
f05ae3c
Compare
92ae1e3
to
05b1424
Compare
gladjohn
reviewed
Mar 21, 2025
gladjohn
reviewed
Mar 21, 2025
gladjohn
reviewed
Mar 21, 2025
gladjohn
reviewed
Mar 21, 2025
gladjohn
reviewed
Mar 21, 2025
gladjohn
approved these changes
Apr 2, 2025
neha-bhargava
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds theaccess_token_sha256_to_refresh
parameter to theacquire_token_for_client
method in themsal.ConfidentialClientApplication
class.This PR meets feature requirements and acceptance criteria.This PR supports
ManagedIdentityClient(..., client_capabilities=["cp1"]).acquire_token_for_client(..., claims_challenge="...")
.Currently, the new behavior will be available for Service Fabric. Other Managed Identity v1 providers may pick up those new behaviors soon. After that happens, we will enable this behavior for more Managed Identity code paths.