Validated that the HEAD response returns the headers.

glynos · glynos · commit ce3bccf87575 · 2013-12-08T10:03:01.000+01:00
diff --git a/http/src/http/v2/client/client.cpp b/http/src/http/v2/client/client.cpp
@@ -6,6 +6,7 @@
 #include <future>
 #include <boost/asio/strand.hpp>
 #include <boost/algorithm/string/trim.hpp>
+#include <boost/algorithm/string/split.hpp>
 #include <boost/algorithm/string/predicate.hpp>
 #include <network/uri.hpp>
 #include <network/config.hpp>
@@ -171,6 +172,14 @@ namespace network {
         }
 
         // fill headers
+        std::istream is(&response_);
+        std::string header;
+        while ((header != "\r") && std::getline(is, header)) {
+          std::vector<string_type> kvp;
+          boost::split(kvp, header, boost::is_any_of(":"));
+          res->add_header(kvp[0], boost::trim_copy(kvp[1]));
+        }
+
         connection_->async_read_until(response_,
                                       "\r\n\r\n",
                                       strand_.wrap(
diff --git a/http/src/network/http/v2/client/response.hpp b/http/src/network/http/v2/client/response.hpp
@@ -152,6 +152,10 @@ namespace network {
 	  return status_message_;
 	}
 
+        void add_header(const string_type &name, const string_type &value) {
+          headers_.push_back(std::make_pair(name, value));
+        }
+
         /**
          * \brief
          */
diff --git a/http/test/v2/features/client/client_test.cpp b/http/test/v2/features/client/client_test.cpp
@@ -34,6 +34,9 @@ Describe(http_client) {
     Assert::That(response.version(), Equals("HTTP/1.1"));
     Assert::That(response.status(), Equals(http::status::code::OK));
     Assert::That(response.status_message(), Equals("OK"));
+
+    auto headers = response.headers();
+    Assert::That(std::begin(headers)->first, Equals("Date"));
   }
 
   std::unique_ptr<http::client> client_;

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,9 @@ Describe(http_client) {`
`34`	`34`	`Assert::That(response.version(), Equals("HTTP/1.1"));`
`35`	`35`	`Assert::That(response.status(), Equals(http::status::code::OK));`
`36`	`36`	`Assert::That(response.status_message(), Equals("OK"));`
	`37`	`+`
	`38`	`+ auto headers = response.headers();`
	`39`	`+ Assert::That(std::begin(headers)->first, Equals("Date"));`
`37`	`40`	`}`
`38`	`41`
`39`	`42`	`std::unique_ptr<http::client> client_;`