MenuButton: Enter key should expand the menu

This patch excludes the Enter key from MenuButton's keydown handler,
and instead allows ToggleButton to handle it. With this change, when
the Enter key is pressed, on keyup it toggles the menu open/closed.

Change-Id: I98159ad0db03f25cc3b01d0d6a3d9fb5bbc8b796
1 file changed
tree: 413e9f0b2456a1f81047625406f55e38fedb012c
  1. .vscode/
  2. build/
  3. packages/
  4. .browserslistrc
  5. .editorconfig
  6. .eslintignore
  7. .eslintrc.js
  8. .gitignore
  9. .gitreview
  10. .mailmap
  11. .npmrc
  12. .nvmrc
  13. .stylelintignore
  14. .stylelintrc.js
  15. AUTHORS.txt
  16. BREAKING_CHANGES.md
  17. CHANGELOG.md
  18. CODE_OF_CONDUCT.md
  19. LICENSE
  20. npm-shrinkwrap.json
  21. package.json
  22. README.md
  23. RELEASING.md
README.md

Codex

Codex is the design system for Wikimedia. The Codex repository contains four packages:

Codex features:

  • Wide-ranging support for internationalization and global usage
  • Web accessibility compliant (Web Content Accessibility Guidelines 2.1 level AA)
  • Comprehensive browser and device support

Quick start

Usage

To install:

npm install --save-dev @wikimedia/codex @wikimedia/codex-icons

To use components:

import { CdxButton, CdxTextInput } from '@wikimedia/codex';

To use icons:

import { cdxIconAlert, cdxIconNewWindow } from '@wikimedia/codex-icons';

For more information on how to set up and use the library, see the usage documentation.

Development

Codex development requires the following:

  • Node: the required version of Node is pinned in .nvmrc. To install and use the required version, run nvm install "$(<.nvmrc)" then nvm use in the root of the repository. Node Version Manager (NVM) is a handy tool that lets you install and switch between multiple versions of Node on your machine. This is especially useful when working on multiple projects that depend on different Node versions.
    Learn more about NVM on GitHub.
  • npm: version 7 or higher is required to support workspaces. You can install latest version of npm with nvm via nvm install --latest-npm.

Helpful commands:

  • npm install in the root of the repository to install requirements for all workspaces
  • npm run doc:dev to start the docs site
  • npm run dev to start the Vite sandbox
  • npm run test:unit -w @wikimedia/codex to run unit tests for e.g. the codex workspace. Read more about testing.

See the contributing code guidelines for more information.

Contributing

If you'd like to contribute, head over to the contributing docs to learn about our processes and ways you can contribute.

Maintainers

Codex is maintained by the Design System Team of the Wikimedia Foundation. It is designed and developed by contributors from the Wikimedia Foundation, Wikimedia Deutschland, and the Wikimedia volunteer community.

To contact us or to learn more about current and future work, visit our workboard or the Design System Team page on mediawiki.org.